Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flamegraph: Prevent cropping of tooltip by bottom of the viewport #70633

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented Jun 23, 2023

Flips the position of the tooltip also vertically so it does not get clipped by bottom of the viewport.

Screenshot 2023-06-23 at 19 53 20

Note:
Fixing this both in V2 version and old version just in case.

@aocenas aocenas requested a review from a team as a code owner June 23, 2023 18:02
@aocenas aocenas added this to the 10.1.x milestone Jun 23, 2023
@aocenas aocenas changed the title Flamegraph: Fix cropping of tooltip when it was show too low on the screen Flamegraph: Prevent cropping of tooltip by bottom of the viewport Jun 23, 2023
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aocenas aocenas modified the milestone: 10.1.x Jun 26, 2023
@aocenas aocenas merged commit 0f2922d into main Jun 26, 2023
25 checks passed
@aocenas aocenas deleted the aocenas/flamegraph/fix-tooltip-vertical-cropping branch June 26, 2023 16:03
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants