I18n: Translate phrases for new Browse Dashboards #70654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bohdanator
requested review from
joshhunt and
JoaoSilvaGrafana
and removed request for
a team
|
|
Bohdanator
changed the title
|
We'll check this more in the week, but to enable a feature flag your grafana server config (custom.ini) should look like this Also be sure to run |
Bohdanator
force-pushed
the
70085-i18n-for-managing-dashboards
branch
from
17af39e
to
68cd489
Compare
joshhunt
changed the title
There was a problem hiding this comment.
@Bohdanator thank you for your contribution, please check the comments I left for you.
| ? t('browse-dashboards.action.deleting', 'Deleting...') | ||
| : t('browse-dashboards.action.delete-button', 'Delete'), | ||
| [isDeleting] | ||
| ); |
There was a problem hiding this comment.
I don't think the useMemo hook is necessary in this case, you can just use the t() function inside the ternary directly
| () => | ||
| isMoving ? t('browse-dashboards.action.moving', 'Moving...') : t('browse-dashboards.action.move-button', 'Move'), | ||
| [isMoving] | ||
| ); |
There was a problem hiding this comment.
See above comment about useMemo hook.
RoxanaAnamariaTurc
approved these changes
Jul 4, 2023
polibb
pushed a commit
that referenced
this pull request
Jul 14, 2023
* Mark strings in folder manager nav for translation * Mark strings in folder actions for translation * Mark strings in new folder modal for translation * Mark strings in delete modal for translation * Mark strings in move modal for translation * Fix interpunction in translations * Run i18n:extract * Fix Manage Permissions drawer test * Redundnt useMemo * Updated extracted translations after resolving conflicts --------- Co-authored-by: Roxana Turc <anamaria-roxana.turc@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR marks strings in the new folder management UI for translation.
Which issue(s) does this PR fix?:
Fixes #70085
Special notes for your reviewer:
I am completely new to this project :). I was able to set up Grafana locally, but I wasn't able to toggle
nestedFoldersfeature. After putting it incustom.iniconfig file nothing happened (also after restart). What else is required?I would also like feedback on the translation IDs. This is my first time working with
i18nor Crowdin, so I'm not sure what else is required for these translation IDs to be added. (Also if the ID structure makes sense.)Please check that: