Login: Adjust error message when user exceed login attempts #70736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoxanaAnamariaTurc
added
add to changelog
area/frontend/login
RoxanaAnamariaTurc
requested review from
tskarhed and
ashharrison90
and removed request for
a team
ashharrison90
requested review from
a team,
vtorosyan and
danielkenlee
and removed request for
a team
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com> Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>
|
@grafana/grafana-authnz-team @grafana/docs-squad any thoughts on these changes? 🤔 |
IevaVasiljeva
approved these changes
Jun 29, 2023
|
The team is happy with the PR being merged. Thanks for improving the auth experience! ❤️ |
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Adjust error message when user exceed login attempts * empty commit to add coauthors Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com> Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com> --------- Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com> Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com> Co-authored-by: tskarhed <1438972+tskarhed@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adjust the error message when user exceed login attempts. Added unit tests as well to prevent regression.
Why do we need this feature?
Users know when they are blocked out of their account.
Who is this feature for?
Everyone.
Which issue(s) does this PR fix?:
Fixes #62037
Special notes for your reviewer:
Please check that: