Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.0.x] Grafana UI: Fix behaviour regression on Tooltip component #70742

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 1cdc139 from #70682


What is this feature?

To fix the behaviour of the Tooltip component.

Why do we need this feature?

In order to recover previous behaviour:

value behaviour
show={undefined} tooltip shown on hover, hidden when no longer hovering
show={true} tooltip is always shown, never hidden
show={false} tooltip is never shown (effectively disabled)

Who is this feature for?

Everybody

Which issue(s) does this PR fix?:

Fixes #70514 but will keep it to discuss further, for example, if would be better to have a disable prop instead.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grafana-delivery-bot grafana-delivery-bot bot requested a review from a team as a code owner June 27, 2023 11:21
@grafana-delivery-bot grafana-delivery-bot bot requested review from eledobleefe and JoaoSilvaGrafana and removed request for a team June 27, 2023 11:21
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.0.x milestone Jun 27, 2023
@grafana-delivery-bot grafana-delivery-bot bot added add to changelog area/frontend area/grafana/ui Issues that belong to components in the @grafana/ui library area/tooltip backport A backport PR type/bug labels Jun 27, 2023
@grafanabot grafanabot added the pr/external This PR is from external contributor label Jun 27, 2023
@eledobleefe eledobleefe enabled auto-merge (squash) June 27, 2023 11:23
Copy link
Contributor

@eledobleefe eledobleefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

@eledobleefe eledobleefe merged commit b78a4d7 into v10.0.x Jun 27, 2023
18 checks passed
@eledobleefe eledobleefe deleted the backport-70682-to-v10.0.x branch June 27, 2023 11:28
@zerok zerok modified the milestones: 10.0.x, 10.0.2 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend area/grafana/ui Issues that belong to components in the @grafana/ui library area/tooltip backport A backport PR pr/external This PR is from external contributor type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants