Alerting: Render folder selector in options for Alert List Panel only when having Grafana datasource #70816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atasource is selected or when Grafana is selected as the datasource
soniaAguilarPeiron
added
area/alerting
soniaAguilarPeiron
changed the title
soniaAguilarPeiron
deleted the
alerting/remmove-folder-from-alert-list-panel-if-no-grafana
branch
harisrozajac
pushed a commit
that referenced
this pull request
Jun 29, 2023
… when having Grafana datasource (#70816) Render folder selector in options for Alert List Panel only when no datasource is selected or when Grafana is selected as the datasource
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
… when having Grafana datasource (#70816) Render folder selector in options for Alert List Panel only when no datasource is selected or when Grafana is selected as the datasource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR modifies the alert list panel to render the folder selector in the options section only when either no datasource is selected or "Grafana" is chosen as the datasource.
Additional this PR makes a small change to the order in which the folder and datasource are displayed.It swaps their positions to improve the user experience.
Why do we need this feature?
This change improves the user experience by providing the folder selector specifically for these scenarios, ensuring relevant options are displayed.
Who is this feature for?
All users
Special notes for your reviewer:
folder-in-alert-panel.mp4
Please check that: