Alerting: Use ToggleTip instead of Hovercard in the info popup on Math expressions #70881
+42
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaAguilarPeiron
added
area/alerting
soniaAguilarPeiron
requested review from
tskarhed,
JoaoSilvaGrafana and
gillesdemey
and removed request for
a team
soniaAguilarPeiron
force-pushed
the
alerting/use-toggletooltip-in-math-expression-info
branch
from
2cb8489
to
635bcea
Compare
soniaAguilarPeiron
force-pushed
the
alerting/use-toggletooltip-in-math-expression-info
branch
from
635bcea
to
8e2ac1a
Compare
JoaoSilvaGrafana
approved these changes
Jun 29, 2023
gillesdemey
approved these changes
Jun 29, 2023
gillesdemey
deleted the
alerting/use-toggletooltip-in-math-expression-info
branch
harisrozajac
pushed a commit
that referenced
this pull request
Jun 29, 2023
…h expressions (#70881) * Use ToggleTip instead of Hovercard in the info popup on Math expressions * Address review comments
soniaAguilarPeiron
restored the
alerting/use-toggletooltip-in-math-expression-info
branch
harisrozajac
pushed a commit
that referenced
this pull request
Jun 30, 2023
…h expressions (#70881) * Use ToggleTip instead of Hovercard in the info popup on Math expressions * Address review comments
soniaAguilarPeiron
deleted the
alerting/use-toggletooltip-in-math-expression-info
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Math expression component to use
ToggleTipinstead ofHoverCard. The motivation behind this change is to address the annoyance caused by accidental popup when hovering over this large modal.In this PR we add also a new optional property in the
ToogleTipcomponent to be able to override themax-widthand not use the fixed 400px we have so far.What is this feature?
All users
Why do we need this feature?
To make a better user experience.
Who is this feature for?
All users.
Special notes for your reviewer:
Before:
before.mp4
After:
after-toggle.mp4
Please check that: