[v9.5.x] Alerting: Migrate unknown NoData\Error settings to the default #70905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
* use default execution if legacy is not known * update docs * Update docs/sources/alerting/migrating-alerts/migrating-legacy-alerts.md Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> * Update docs/sources/alerting/migrating-alerts/migrating-legacy-alerts.md Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> --------- Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> (cherry picked from commit 3af95be)
grafana-delivery-bot
bot
added
add to changelog
area/alerting
|
Looks like the docs portion of this was already backported in #69055 |
JacobsonMT
approved these changes
Jun 29, 2023
yuri-tceretian
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3af95be from #68403
What is this feature?
It fixes migration to not fail if legacy alert rule settings
noDataStateorexecutionErrorStatecontain unknown values. Instead, it migrates such settings to the default settings which areNoDatafor no data andErrorfor Error handling and emits a warning message such as"Unable to translate execution of NoData state. Using default execution"for No Data setting or"Unable to translate execution of Error state. Using default execution"for Error setting.Why do we need this feature?
This will make migration more smooth.
Who is this feature for?
If rule is created via UI, the user is not allowed to specify an arbitrary string for those settings.
Which issue(s) does this PR fix?:
Fixes #67851
Special notes for your reviewer:
Please check that: