Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.0.x] Loki: Fix wrong query expression with inline comments #70948

Merged
merged 1 commit into from
Jun 30, 2023
Merged

[v10.0.x] Loki: Fix wrong query expression with inline comments #70948

merged 1 commit into from
Jun 30, 2023

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 13dd821 from #70947

What is this feature?

When using multiline queries with comments, we are currently generating wrong query expressions.

E.g.

{app="foo"}
# test
|= `bar`

will be parsed to

{app="foo"}

With this PR it will be

{app="foo"}

|= `bar`

@svennergr @grafana-delivery-bot
Loki: Fix wrong query expression with inline comments (#70947)
c573194 
fix remove comments from query

(cherry picked from commit 13dd821)
@grafana-delivery-bot grafana-delivery-bot bot requested a review from a team as a code owner June 30, 2023 09:37
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.0.x milestone Jun 30, 2023
@grafanabot grafanabot added the pr/external This PR is from external contributor label Jun 30, 2023
@svennergr svennergr enabled auto-merge (squash) June 30, 2023 09:38
@svennergr svennergr merged commit 0e092ba into v10.0.x Jun 30, 2023
16 of 17 checks passed
@svennergr svennergr deleted the backport-70947-to-v10.0.x branch June 30, 2023 09:44
@github-actions
Copy link
Contributor

Backend code coverage report for PR #70948
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #70948

Plugin Main PR Difference
loki 85.24% 84.72% -.52%

@zerok zerok modified the milestones: 10.0.x, 10.0.3 Jul 18, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 26, 2023
Merged
@jdbaldry jdbaldry mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svennergr svennergr svennergr approved these changes

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR datasource/Loki pr/external This PR is from external contributor type/bug
Projects
None yet
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@svennergr @zerok @grafanabot