Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.0.x] AzureMonitor: Fix metric names for multi-resources. #70994

Merged
merged 1 commit into from Jun 30, 2023
Merged

[v10.0.x] AzureMonitor: Fix metric names for multi-resources. #70994

merged 1 commit into from Jun 30, 2023

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport f32f185 from #70864

What is this feature?
When building a query for multiple resources only a subset of metrics are valid and that selection is only available via the API version 2017-12-01-preview.

To verify

  • Head over to explore for AzureMonitor
  • Select a single VM instance and note one of the Metric Names is "Inbound Flows"
  • Open the Resource Picker back up and select another VM
  • Note that "Inbound Flows" is no longer available in the Metric Names dropdown.

Fixes #68603

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@asimpson @grafana-delivery-bot
AzureMonitor: Fix metric names for multi-resources. (#70864)
6d15524 
When building a query for multiple resources only a subset of metrics
are valid and that selection is only available via the API version `2017-12-01-preview`.

fixes #68603

(cherry picked from commit f32f185)
@grafana-delivery-bot grafana-delivery-bot bot requested a review from a team as a code owner June 30, 2023 15:37
@grafana-delivery-bot grafana-delivery-bot bot requested review from asimpson and aangelisc and removed request for a team June 30, 2023 15:37
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.0.x milestone Jun 30, 2023
@grafanabot grafanabot added the pr/external This PR is from external contributor label Jun 30, 2023
@github-actions
Copy link
Contributor

Backend code coverage report for PR #70994
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #70994

Plugin Main PR Difference
azuremonitor 86.15% 84.65% -1.50%

@asimpson asimpson enabled auto-merge (squash) June 30, 2023 15:53
@asimpson asimpson merged commit df3e56a into v10.0.x Jun 30, 2023
18 checks passed
@asimpson asimpson deleted the backport-70864-to-v10.0.x branch June 30, 2023 16:01
@zerok zerok modified the milestones: 10.0.x, 10.0.3 Jul 18, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 26, 2023
Merged
@jdbaldry jdbaldry mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson asimpson approved these changes

@aangelisc aangelisc Awaiting requested review from aangelisc aangelisc is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR datasource/Azure Azure Monitor Datasource pr/external This PR is from external contributor type/bug
Projects
None yet
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asimpson @zerok @grafanabot