PluginExtensions: Add category to link extensions

[mckn]

What is this feature?
To prevent extensions for repeating their origin as part of the title we have introduced the possibility to define a category that the extensions will be group below.

Before:

After:

Why do we need this feature?
It will improve the user experience and make it easier for the end user to find what they are looking for.

Who is this feature for?
plugin developers, end users

Which issue(s) does this PR fix?:
Fixes #69291

Special notes for your reviewer:

Please check that:

• It works as expected from a user's perspective.
• If this is a pre-GA feature, it is behind a feature toggle.
• The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

[mckn]

@sd2k maybe something we can use in ML?

[sd2k]

Yep this looks useful for ML! Should be backwards compatible too which is ace 🎉

[jackw]

LGTM! 🚀

[sd2k]

Should be backwards compatible too which is ace 🎉

Hmm I'm not actually sure this is true (in some senses) - if I add the category field to my extension link then they aren't shown in Grafana 10.0 😞 I guess there's something in Grafana's getExtensionLinks which checks for unknown properties? Not much that can be done about that now though, I'll just wait for this to be released before adding the category.

Edit:

FYI the error I see in the logs is:

[Plugin Extensions] Invalid extension "Create forecast". Trying to override not-allowed properties: category

[mckn]

Should be backwards compatible too which is ace 🎉

Hmm I'm not actually sure this is true (in some senses) - if I add the category field to my extension link then they aren't shown in Grafana 10.0 😞 I guess there's something in Grafana's getExtensionLinks which checks for unknown properties? Not much that can be done about that now though, I'll just wait for this to be released before adding the category.

Edit:

FYI the error I see in the logs is:

[Plugin Extensions] Invalid extension "Create forecast". Trying to override not-allowed properties: category

Is it a warning or an error? We probably print something like this for the developers but I will make sure it is an error and that it only is printed if you are running Grafana in development mode.

[sd2k]

It's logged to the console as a warning 👍

[mckn]

It's logged to the console as a warning 👍

But it will still show the extension, right? Or will it disable the extension after that warning. If that is the case we probably have a bug.

[sd2k]

It disables the extension 😞 (just to make sure, I'm talking about when trying to use extensions with a category with Grafana versions older than this PR)

[mckn]

It disables the extension 😞 (just to make sure, I'm talking about when trying to use extensions with a category with Grafana versions older than this PR)

Oh, then I need to fix that for 10.1.0 and probably backport it to next 10.0.x release. We should print a warning, ignore the property but not disable the extension in this scenario.

[mckn]

Thanks for reporting this! 🙏🏻 I will fix this during the day tomorrow.