Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.0.x] TimePicker: Fix issue with previous fiscal quarter not parsing correctly #71093

Merged
merged 1 commit into from Jul 5, 2023
Merged

[v10.0.x] TimePicker: Fix issue with previous fiscal quarter not parsing correctly #71093

merged 1 commit into from Jul 5, 2023

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport ab09c9e from #71083

What is this feature?

  • fixes a bug where using the Previous fiscal quarter option with a custom fiscal year start month would not parse correctly
  • adds some unit tests to prevent regressions

Why do we need this feature?

  • when setting a fiscal year start month to later in the year the datemath parsing would not work correctly

Who is this feature for?

  • anyone using previous fiscal quarters

Which issue(s) does this PR fix?:

Fixes https://github.com/grafana/support-escalations/issues/6609

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 @grafana-delivery-bot
TimePicker: Fix issue with previous fiscal quarter not parsing correc…
0426856 
…tly (#71083)

* fix issue with previous fiscal quarter not parsing correctly

* add comment

(cherry picked from commit ab09c9e)
@grafana-delivery-bot grafana-delivery-bot bot requested review from a team as code owners July 5, 2023 16:04
@grafana-delivery-bot grafana-delivery-bot bot requested review from ashharrison90 and eledobleefe and removed request for a team July 5, 2023 16:04
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.0.x milestone Jul 5, 2023
@grafana-delivery-bot grafana-delivery-bot bot removed the request for review from a team July 5, 2023 16:04
@grafana-delivery-bot grafana-delivery-bot bot requested a review from mckn July 5, 2023 16:04
@grafana-delivery-bot grafana-delivery-bot bot added area/frontend backport A backport PR timepicker The time picker is used on explore & dashboards type/bug labels Jul 5, 2023
ashharrison90
ashharrison90 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm bot 🤖

@ashharrison90 ashharrison90 enabled auto-merge (squash) July 5, 2023 16:04
@grafanabot grafanabot added the pr/external This PR is from external contributor label Jul 5, 2023
@ashharrison90 ashharrison90 merged commit 2527d65 into v10.0.x Jul 5, 2023
17 checks passed
@ashharrison90 ashharrison90 deleted the backport-71083-to-v10.0.x branch July 5, 2023 16:12
@zerok zerok modified the milestones: 10.0.x, 10.0.3 Jul 18, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 26, 2023
Merged
@jdbaldry jdbaldry mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashharrison90 ashharrison90 ashharrison90 approved these changes

@eledobleefe eledobleefe Awaiting requested review from eledobleefe eledobleefe is a code owner automatically assigned from grafana/grafana-frontend-platform

@mckn mckn Awaiting requested review from mckn mckn is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR pr/external This PR is from external contributor timepicker The time picker is used on explore & dashboards type/bug
Projects
None yet
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashharrison90 @zerok @grafanabot