Annotations: Improve updating annotation tags queries #71201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakjur
requested review from
mildwonkey,
suntala and
yangkb09
and removed request for
a team
papagian
approved these changes
Jul 7, 2023
| // WithTransactionalDbSession creates a new SQL transaction to ensure consistency | ||
| // for the database operations done within the [sqlstore.DBTransactionFunc]. | ||
| // It's better to combine InTransaction and WithDbSession instead, as the context | ||
| // variable is not updated when using this method. | ||
| WithTransactionalDbSession(ctx context.Context, callback sqlstore.DBTransactionFunc) error |
There was a problem hiding this comment.
I wonder if we could deprecate this
There was a problem hiding this comment.
I was thinking about that, but I think we have a linter that wouldn't be too happy with that 🤔
| WithTransactionalDbSession(ctx context.Context, callback sqlstore.DBTransactionFunc) error | ||
| // WithDbSession runs database operations either in an existing transaction available | ||
| // through [context.Context] or if that's not present, as non-transactional database |
There was a problem hiding this comment.
maybe it would be good mentioning that runs inside transaction if it's under the scope of sqlstore.InTransaction()
sarahzinger
pushed a commit
that referenced
this pull request
Aug 1, 2023
Annotations: Improve annotation tag updates
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
Annotations: Improve annotation tag updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
While working on #71199, I noticed that we're currently deleting all tags related to an annotation and then recreating them one by one when updating annotations with new tags. This provides an attempt at unifying that creation so that only the set of differing tags will be created/deleted.
Why do we need this feature?
🤷 We don't really need it, it took me a while to figure out what the original problem was, and I had already done this refactoring at that time.
It should be more performant given enough operations, but I have not validated that.
Who is this feature for?
Heavy users of annotations.
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: