Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanelInspect: Clean table display settings from field config #71226

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Jul 7, 2023

In order for the fix to work we have to always disable field config in PanelQueryRunner. This is fine as it was applied later anyway in getProcessedData.

Issue: https://github.com/grafana/support-escalations/issues/6562

@torkelo torkelo requested a review from a team as a code owner July 7, 2023 16:25
@torkelo torkelo requested review from ivanortegaalba and juanicabanas and removed request for a team July 7, 2023 16:25
@torkelo torkelo added this to the 10.1.x milestone Jul 7, 2023
@torkelo torkelo added add to changelog no-backport Skip backport of PR labels Jul 7, 2023
Copy link
Contributor

@juanicabanas juanicabanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@torkelo torkelo merged commit 9f2baaf into main Jul 10, 2023
13 checks passed
@torkelo torkelo deleted the inspect-clean-fieldconfig branch July 10, 2023 14:27
polibb pushed a commit that referenced this pull request Jul 14, 2023
* Does not work, hmm..

* now it works

* fixing and refactoring

* remove unused import
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants