AzureMonitor: Add switch to control time-range for Logs queries #71278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default intersectTime property to false
- Add intersectTime field - Update tests - Update mocks - Add onChange function
- Appropriately set intersectTime for logs queries - intersectTime is always true for Traces queries - Update tests
aangelisc
added
effort/small
datasource/Azure
aangelisc
requested review from
asimpson,
alyssabull,
L-M-K-B,
eledobleefe and
mckn
and removed request for
a team
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
grafana-delivery-bot
bot
added
the
backport-failed
aangelisc
removed
type/bug
backport-failed
|
Due to additional complexities around schema changes this will not be backported. |
This was referenced Jul 18, 2023
linoman
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Update types * Update migration - Default intersectTime property to false * Update frontend components - Add intersectTime field - Update tests - Update mocks - Add onChange function * Update backend - Appropriately set intersectTime for logs queries - intersectTime is always true for Traces queries - Update tests * Update docs * Fix test and lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on community feedback the move to implicitly using the Grafana time-range has caused some unexpected behaviour. This change adds a switch to allow users to control the behaviour. Setting the switch to
Querywill ensure that only time-ranges specified within the query are used. Setting the switch toIntersectionwill make use of the Grafana time-range intersected with any time-ranges specified within the query. The default behaviour is to use theQuerytime-ranges only.Fixes #71180
Related: