Dashboard: Slider overlapping with right input field #71282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develer
requested review from
joshhunt and
JoaoSilvaGrafana
and removed request for
a team
Co-authored-by: Joao Silva <100691367+JoaoSilvaGrafana@users.noreply.github.com>
Develer
changed the title
3 tasks
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
* fix(slider): input field left margin * fix(slider): use theme spacing variable Co-authored-by: Joao Silva <100691367+JoaoSilvaGrafana@users.noreply.github.com> --------- Co-authored-by: Joao Silva <100691367+JoaoSilvaGrafana@users.noreply.github.com> (cherry picked from commit 4206a4d)
polibb
pushed a commit
that referenced
this pull request
Jul 14, 2023
* fix(slider): input field left margin * fix(slider): use theme spacing variable Co-authored-by: Joao Silva <100691367+JoaoSilvaGrafana@users.noreply.github.com> --------- Co-authored-by: Joao Silva <100691367+JoaoSilvaGrafana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
There is a slider component on the field config right-side component. The slider's top range number is overlapping with the right-standing input field.
Current view:
Possible solution (align number by the right edge of slider):
I decided to go a bit different way and just added left-margin based on Grafana Labs Storybook. Works fine for me. I think in most case scenarios max value is 100 so it shouldn't be any overlapping.
Which issue(s) does this PR fix?:
Fixes #71220
Special notes for your reviewer:
Please check that: