Auth: Move LDAP debug to Authentication menu #71285
Conversation
Jguer
requested review from
L-M-K-B,
eledobleefe,
linoman,
IevaVasiljeva,
sakjur,
papagian,
zserge,
alexanderzobnin,
eleijonmarck and
a team
and removed request for
a team
| ac.EvalPermission(ac.ActionSettingsWrite, ac.ScopeSettingsSAML), | ||
| ac.EvalPermission(ac.ActionSettingsRead, ac.ScopeSettingsSAML), | ||
| ), ac.EvalPermission(ac.ActionLDAPStatusRead)) | ||
| } |
There was a problem hiding this comment.
one issue that this PR raises is to have the ScopeSettingsLDAP ready. could we add that as a follow up issue ?
There was a problem hiding this comment.
👍 you want me to do it?
There was a problem hiding this comment.
LGTM, this could be merged before a big refactor of the UI from this PR. Ideally we would merge this PR first and then we could merged the conflicts into the bigger PR with the refactored states
oss - #71200
enterprise - https://github.com/grafana/grafana-enterprise/pull/5398
|
👍 I do agree it requires some frontend rework, I'll trust you on that and can review once rebased |
* move LDAP page to Authentication * tweak Auth menu showing permissions
|
I don't see the Authentication under Administration menu, so I'm not be able to use LDAP Test user mapping. |
Ditto. Maybe it only shows up if you have enterprise licensing so the SAML option would also be available? We're running Grafana Enterprise on-prem 10.1.0 without licensing, and the option is missing for us as well. |
What is this feature?
When LDAP is disabled card won't show
This keeps the current behavior until extra LDAP configuration is added
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: