Logs: Display log row menu cell on displayed fields #71300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyax
force-pushed
the
matyax/log-actions-displayed-fields
branch
from
05e48f6
to
4956d7a
Compare
polibb
pushed a commit
that referenced
this pull request
Jul 14, 2023
* LogRowMenuCell: create component * LogRowMessage: use new LogRowMenuCell component * LogRowMessage: turn into functional component * LogRowMenuCell: memoize component * LogRowMessage: remove cx * LogMessage: create component from function * LogRowMessageDisplayedFields: turn into component * LogRowMessageDisplayedFields: add LogRowMenuCell * LogRowMessageDisplayedFields: rename prop and pass missing context prop * LogRowMessageDisplayedFields: add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the log row menu code to a new component, and uses it in
LogRowMessageandLogRowMessageDisplayedFieldsso we can show the menu in both log row render modes.Additional changes:
cx(see LogsPanel: Performance issues #60687)renderLogMessageinto a component.Which issue(s) does this PR fix?:
Fixes #70217
Special notes for your reviewer:
Nothing should really change, with the exception of having the log row menu when we select fields to display.
Before:
After: