Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Config: Add new units (mΩ, kHz, MHz, GHz, ac, ha) #71357

Merged
merged 4 commits into from Jul 14, 2023

Conversation

Develer
Copy link
Contributor

@Develer Develer commented Jul 11, 2023

What is this feature?

Added the following new units:

  • Milliohm (mΩ) unit was added to the list of units
  • Kilohertz (kHz)
  • Megahertz (MHz)
  • Gigahertz (GHz)
  • Acres (ac)
  • Hectares (ha)

Why do we need this feature?

There are scenarios that need additional units on axes.

Which issue(s) does this PR fix?:

Fixes #70680

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Develer Develer added area/frontend add to changelog backport v9.1.x Bot will automatically open backport PR area/dataviz Anything that relates to Data Visualisation work but is not specific to one panel labels Jul 11, 2023
@Develer Develer added this to the 10.1.x milestone Jul 11, 2023
@Develer Develer self-assigned this Jul 11, 2023
@Develer Develer requested review from a team as code owners July 11, 2023 12:10
@Develer Develer requested review from joshhunt, JoaoSilvaGrafana and academo and removed request for a team July 11, 2023 12:10
@grafana-delivery-bot
Copy link
Contributor

Hello @Develer!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@Develer Develer added backport v10.0.x and removed backport v9.1.x Bot will automatically open backport PR missing-labels labels Jul 11, 2023
@grafana-delivery-bot
Copy link
Contributor

Hello @Develer!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@Develer Develer added no-backport Skip backport of PR and removed backport v10.0.x labels Jul 11, 2023
@Develer Develer changed the title feat(units): add new unit mohm Field Config: A new mOhm unit added Jul 11, 2023
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this! I think we may want to consider addressing the other user requested units from the same issue in terms of adding various other units (especially hertz).

As part of this we should test / verify that autoscaling can be supported (i.e. 3000 ms -> 3s etc.)

@nmarrs nmarrs changed the title Field Config: A new mOhm unit added Field Config: A new units (mΩ, kHz, MHz, GHz, ac, ha) Jul 14, 2023
@nmarrs nmarrs changed the title Field Config: A new units (mΩ, kHz, MHz, GHz, ac, ha) Field Config: Add new units (mΩ, kHz, MHz, GHz, ac, ha) Jul 14, 2023
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
image

@nmarrs nmarrs merged commit 8ced434 into main Jul 14, 2023
16 checks passed
@nmarrs nmarrs deleted the 70680-new-unit-mohm branch July 14, 2023 19:09
@adela-almasan adela-almasan mentioned this pull request Jul 28, 2023
20 tasks
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/dataviz Anything that relates to Data Visualisation work but is not specific to one panel area/frontend no-backport Skip backport of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Units: mOhm missing
3 participants