Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y: Fix keyboard accessibility in LayerDragDropList #71386

Merged
merged 1 commit into from
Jul 12, 2023
Merged

A11y: Fix keyboard accessibility in LayerDragDropList #71386

merged 1 commit into from
Jul 12, 2023

Conversation

Develer
Copy link
Contributor

@Develer Develer commented Jul 11, 2023 •
edited by nmarrs
Loading

What is this feature?

This update assigns a role to non-button element to fix accessibility issue.

Which issue(s) does this PR fix?:

Fixes #70965

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Develer Develer added area/frontend add to changelog no-backport Skip backport of PR area/dataviz Anything that relates to Data Visualisation work but is not specific to one panel labels Jul 11, 2023
@Develer Develer added this to the 10.1.x milestone Jul 11, 2023
@Develer Develer self-assigned this Jul 11, 2023
@Develer Develer requested a review from a team as a code owner July 11, 2023 15:46
nmarrs
nmarrs approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Develer Develer merged commit d9057c0 into main Jul 12, 2023
22 checks passed
@Develer Develer deleted the 70965-a11y-dnd-layout branch July 12, 2023 12:14
polibb pushed a commit that referenced this pull request Jul 14, 2023
@Develer @polibb
A11y: Fix keyboard accessibility in LayerDragDropList (#71386)
7372145 
fix(a11y): drag and drop layer list
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarrs nmarrs nmarrs approved these changes

Assignees

@Develer Develer

Labels
add to changelog area/dataviz Anything that relates to Data Visualisation work but is not specific to one panel area/frontend no-backport Skip backport of PR
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

A11y: Fix keyboard accessibility in public/app/core/components/Layers/LayerDragDropList.tsx
3 participants
@Develer @nmarrs @ricky-undeadcoders