Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: Save tags on dashboard creation #71394

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

evictorero
Copy link
Contributor

@evictorero evictorero commented Jul 11, 2023

What is this feature?

When creating a dashboard with tags we weren't persisting them.
There is a flag copyTags which is false by default and we are using it to clear the tags array. When a dashboard is created, we shouldn't erase those tags.
Added a change to evaluate this flag along with isNew bool which indicates if this is a new dashboard or not.

Fixes #71387

Special notes for your reviewer:
How to test it:

Create a new dashboard

  • Go to dashboard settings
  • Add a tag
  • Save the dashboard
  • Validate the tag is being saved

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@evictorero evictorero added this to the 10.1.x milestone Jul 11, 2023
@evictorero evictorero requested a review from a team as a code owner July 11, 2023 17:12
@evictorero evictorero requested review from ivanortegaalba and polibb and removed request for a team July 11, 2023 17:12
@evictorero evictorero added the no-backport Skip backport of PR label Jul 11, 2023
Copy link
Contributor

@juanicabanas juanicabanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evictorero evictorero merged commit 290deca into main Jul 13, 2023
24 checks passed
@evictorero evictorero deleted the evictorero/fix-save-tags-on-dashboard-creation branch July 13, 2023 12:10
polibb pushed a commit that referenced this pull request Jul 14, 2023
Dashboards: save tags on dashboard creation
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: tags not persisted when saving a new dashboard
4 participants