Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.0.x] AppChromeService: Fixes update to breadcrumb parent URL #71418

Merged
merged 1 commit into from Jul 12, 2023

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Jul 12, 2023

Backport dc71d36 from #71410


This was already fixed in main (10.1) but not in 10.0 via #68673

This just tweaks that fix and makes it easier to backport in isolation.

AppChromeService: Fixes update to parent url
(cherry picked from commit dc71d36)
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want these plugin version changes? 😬

Copy link
Member Author

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashharrison90 no idea, they are added automatically. Not sure why / what the thinking is (why it's checked in?)

@ashharrison90
Copy link
Contributor

Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🙌

@torkelo torkelo merged commit 1f13067 into v10.0.x Jul 12, 2023
17 checks passed
@torkelo torkelo deleted the backport-71410-to-v10.0.x branch July 12, 2023 11:38
@zerok zerok modified the milestones: 10.0.x, 10.0.3 Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants