Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin: Validate plugin version on installation #71488

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Plugin: Validate plugin version on installation #71488

merged 1 commit into from
Jul 17, 2023

Conversation

oshirohugo
Copy link
Contributor

What is this feature?

Validates plugin version provided as an argument to the cli on plugin installation

Why do we need this feature?

This feature is needed to provide a better user experience on cli usage

Who is this feature for?

grafana cli users

Special notes for your reviewer:

This is a followup from:
#71355

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@oshirohugo oshirohugo requested a review from a team as a code owner July 12, 2023 16:04
@oshirohugo oshirohugo requested review from sakjur, papagian and zserge and removed request for a team July 12, 2023 16:04
@oshirohugo oshirohugo added this to the 10.1.x milestone Jul 12, 2023
andresmgot
andresmgot approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (no need to be super strict, as far as versions are semver-ish, it should be fine)

@oshirohugo oshirohugo merged commit 2776a00 into main Jul 17, 2023
19 checks passed
@oshirohugo oshirohugo deleted the add-plugin-version-validation-on-installation branch July 17, 2023 08:22
linoman pushed a commit that referenced this pull request Jul 24, 2023
@oshirohugo @linoman
Plugin: Validate plugin version on installation (#71488)
32bd9ff
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

@sakjur sakjur Awaiting requested review from sakjur sakjur was automatically assigned from grafana/backend-platform

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

Assignees

@oshirohugo oshirohugo

Labels
add to changelog area/backend area/grafana-cli no-backport Skip backport of PR
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oshirohugo @andresmgot @ricky-undeadcoders @grafanabot