Explore: Remove exploreMixedDatasource feature toggle #71534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Open the links below in a new tab to go to the correct steps)
|
grafanabot
added
the
levitate breaking change
Elfo404
requested review from
grafanabot,
a team,
Eve832 and
GrafanaWriter
as code owners
Elfo404
requested review from
jcalisto,
dafydd-t,
tskarhed and
JoaoSilvaGrafana
and removed request for
a team
|
Backend code coverage report for PR #71534 |
|
Frontend code coverage report for PR #71534
|
harisrozajac
approved these changes
Jul 13, 2023
ifrost
approved these changes
Jul 14, 2023
public/app/core/utils/explore.ts
Outdated
| @@ -75,21 +75,6 @@ export async function getExploreUrl(args: GetExploreUrlArguments): Promise<strin | |||
| .filter((t) => t.datasource?.uid !== ExpressionDatasourceUID); | |||
| let url: string | undefined; | |||
| // if the mixed datasource is not enabled for explore, choose only one datasource | |||
There was a problem hiding this comment.
Suggested change
| // if the mixed datasource is not enabled for explore, choose only one datasource |
gelicia
reviewed
Jul 14, 2023
There was a problem hiding this comment.
There's a couple mentions of allowMixed in this that I can't make suggested changes on bc they're too far from the other changes.
gelicia
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Removes the
exploreMixedDatasourcefeature flag. The flag was enabled by default in 10.0.0 and no issues has been reported about itWhich issue(s) does this PR fix?:
Fixes #52417
Special notes for your reviewer:
Please check that:
a couple of now irrelevant tests have been removed. Please test that: