Alerting: Save and restore condition reference while switching type #71629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaAguilarPeiron
added
area/alerting
soniaAguilarPeiron
requested review from
gillesdemey,
armandgrillet,
VikaCep and
konrad147
and removed request for
a team
VikaCep
approved these changes
Jul 17, 2023
soniaAguilarPeiron
deleted the
alerting/save-restore-condition-while-switching-type
branch
linoman
pushed a commit
that referenced
this pull request
Jul 24, 2023
…71629) Save and restore condition reference while switching type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR saves and restores condition reference in the alert rule form when creating a new rule and switching between types.
The problem was that once user switch to cloud rule type the condition is set to the query and we loose this reference to the grafana managed expression or query condition.
Why do we need this feature?
We want to help user to keep the options they have while switching between alert rule types.
Who is this feature for?
All users.
Special notes for your reviewer:
Before this change:
conditionKO.mp4
After the change:
conditionOK.mp4
Please check that: