Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units: Added support for Candela (cd) #71696

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Units: Added support for Candela (cd) #71696

merged 1 commit into from
Jul 19, 2023

Conversation

Frankkkkk
Copy link
Contributor

Hi,

What is this feature?

Adds the Candela cd unit

Why do we need this feature?

Basic unit of the SI system

Who is this feature for?

Physicists

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Frankkkkk Frankkkkk requested review from a team as code owners July 15, 2023 23:35
@Frankkkkk Frankkkkk requested review from tskarhed, JoaoSilvaGrafana and mckn and removed request for a team July 15, 2023 23:35
@CLAassistant
Copy link

CLAassistant commented Jul 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@grafanabot grafanabot added area/frontend pr/external This PR is from external contributor labels Jul 15, 2023
mckn
mckn approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mckn mckn added this to the 10.1.x milestone Jul 19, 2023
@mckn mckn added add to changelog no-backport Skip backport of PR labels Jul 19, 2023
@mckn mckn changed the title Field Config: Add new unit cd (Candela) Units: Added support for Candela (cd) Jul 19, 2023
@mckn mckn merged commit 3b257b1 into grafana:main Jul 19, 2023
24 checks passed
linoman pushed a commit that referenced this pull request Jul 24, 2023
@Frankkkkk @linoman
Units: Added support for Candela (cd) (#71696)
6d5f45b 
Field Config: Add new unit cd (Candela)
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mckn mckn mckn approved these changes

@tskarhed tskarhed Awaiting requested review from tskarhed tskarhed is a code owner automatically assigned from grafana/grafana-frontend-platform

@JoaoSilvaGrafana JoaoSilvaGrafana Awaiting requested review from JoaoSilvaGrafana JoaoSilvaGrafana is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees
No one assigned
Labels
add to changelog area/frontend no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Frankkkkk @CLAassistant @mckn @ricky-undeadcoders @grafanabot