Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.0.x] Auth: Add support for custom signing keys in auth.azure_ad #71708

Merged
merged 1 commit into from
Jul 17, 2023
Merged

[v10.0.x] Auth: Add support for custom signing keys in auth.azure_ad #71708

merged 1 commit into from
Jul 17, 2023

Conversation

Jguer
Copy link
Contributor

@Jguer Jguer commented Jul 17, 2023

Backport fbfdd6b from #71365

What is this feature?

  • Cache on client ID and not scraped tenant ID
  • Try app_id scoped keyset and then general keyset
  • When cached JWKS fails, retry web keyset
  • Change default cache storage time to 5 min

Fixes #71325

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Jguer
Auth: Add support for custom signing keys in auth.azure_ad (#71365)
9f934dd 
* fallthrough JWKS validation and caching for Azure

* remove unused field

(cherry picked from commit fbfdd6b)
@Jguer Jguer added area/backend add to changelog backport A backport PR product-approved Pull requests that are approved by product/managers and are allowed to be backported labels Jul 17, 2023
@Jguer Jguer added this to the 10.0.x milestone Jul 17, 2023
@Jguer Jguer requested a review from a team as a code owner July 17, 2023 08:03
@Jguer Jguer self-assigned this Jul 17, 2023
@Jguer Jguer requested review from linoman and IevaVasiljeva and removed request for a team July 17, 2023 08:03
IevaVasiljeva
IevaVasiljeva approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@IevaVasiljeva IevaVasiljeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after a quick skim through, as this is a backport. Let me know if you want a thorough review.

@Jguer
Copy link
Contributor Author

Jguer commented Jul 17, 2023

@IevaVasiljeva if you've seen some things that can be better can you mention them in #71717 ? I can take the opportunity to implement some

@Jguer Jguer modified the milestone: 10.0.x Jul 17, 2023
@Jguer Jguer merged commit 8c22371 into v10.0.x Jul 17, 2023
16 checks passed
@Jguer Jguer deleted the backport-71365-to-v10.0.x branch July 17, 2023 14:27
@zerok zerok modified the milestones: 10.0.x, 10.0.3 Jul 18, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 26, 2023
Merged
@jdbaldry jdbaldry mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linoman linoman linoman approved these changes

@IevaVasiljeva IevaVasiljeva IevaVasiljeva approved these changes

Assignees

@Jguer Jguer

Labels
add to changelog area/backend backport A backport PR product-approved Pull requests that are approved by product/managers and are allowed to be backported
Projects
None yet
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jguer @linoman @IevaVasiljeva @zerok