Trace to logs: Add service name and namespace to default tags

[connorlindsey]

What is this feature?

Updates the default trace to logs tags to include service.name, service.namespace, and deployment.environment, which are from the OpenTelemetry standard conventions.

Why do we need this feature?

Makes trace to logs work for services instrumented with OTel

Who is this feature for?

OTel users

Which issue(s) does this PR fix?:

Fixes #71767

Special notes for your reviewer:

[github-actions]

Backend code coverage report for PR #71776
No changes

[github-actions]

Frontend code coverage report for PR #71776

Plugin	Main	PR	Difference
explore	86.41%	86.41%	0%

[cyrille-leclerc]

I'm not clear on the role of these tags but would it be relevant to also add deployment.environment if we add service.namespace and service.name?

By the way, shall we update the documentation https://grafana.com/docs/grafana/next/datasources/tempo/#trace-to-logs as it is listing those default tags?

[joey-grafana]

This looks good overall, thanks for creating the PR.

This will render the Related logs button in the trace view for a row even if the user has not configured any trace to logs tags in their data source configuration. This allows us to guess some of the tags that may be present in the users logs configuration and if they are, then we allow them to link from their trace to the relevant logs. Connor what do you think about adding deployment.environment too.. is this something that you see commonly used?

Also, I would replace line 152 in createSpanLink with the following const tagsToUse = traceToLogsOptions.tags && traceToLogsOptions.tags.length > 0 ? traceToLogsOptions.tags : defaultKeys; as it won't work if the user has previously selected tags but has since deleted them as traceToLogsOptions.tags will not be undefined, it will simply be an empty array.

[joey-grafana]

Ohh yes also we should update the default tags referenced in the docs and the tooltip in the configuration page to match exactly with the default tags we've added in our code.

[cyrille-leclerc]

Thanks @joey-grafana . View related logs is a great feature.

@connorlindsey I think we will benefit of deployment.environment as well as it's what we recommend to segregate production and non production environments. deployment.environment is recommended in our integration tiles...

[connorlindsey]

@joey-grafana Thanks for the feedback. We may actually have to use a custom query for the plugin, so setting the default tags may not work (although this could still be a valid improvement for Explore). If that's the case, we'll handle it by transforming the dataframes in the plugin, but I'll still finish this PR.

[joey-grafana]

Looks good, apart from one suggestion.. thank you for the updates :)

[joey-grafana]

@connorlindsey just updated the milestone :)