Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.0.x] AzureMonitor: Fix resource selection growing over resource selection table #71862

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[v10.0.x] AzureMonitor: Fix resource selection growing over resource selection table #71862

merged 1 commit into from
Jul 18, 2023

Conversation

adamyeats
Copy link
Contributor

Backport 409eae6 from #71463

Fixes #68306.

This PR fixes an issue where, when choosing multiple resources using the resource picker in the Explore view, eventually the current selection grows beyond the table where you can select new resources, leading to the inability to select more.

Screen.Recording.2023-07-12.at.15.35.12.mov

@adamyeats
AzureMonitor: Fix resource selection growing over resource selection …
a54961d 
…table (#71463)

* AzureMonitor: Fix resource selection growing over resource selection table

* Unstick ResourcePicker footer, fix sizing

(cherry picked from commit 409eae6)
@adamyeats adamyeats added this to the 10.0.x milestone Jul 18, 2023
@adamyeats adamyeats self-assigned this Jul 18, 2023
@adamyeats adamyeats requested review from a team as code owners July 18, 2023 14:41
@adamyeats adamyeats requested review from asimpson, bossinc, aangelisc, alyssabull and kaydelaney and removed request for a team July 18, 2023 14:41
@adamyeats adamyeats enabled auto-merge (squash) July 18, 2023 14:43
@adamyeats adamyeats merged commit 55784a2 into v10.0.x Jul 18, 2023
20 checks passed
@adamyeats adamyeats deleted the backport-71463-to-v10.0.x branch July 18, 2023 14:51
@github-actions
Copy link
Contributor

Backend code coverage report for PR #71862
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #71862

Plugin Main PR Difference
azuremonitor 86.15% 84.65% -1.50%

@zerok zerok modified the milestones: 10.0.x, 10.0.4, 10.0.3 Aug 22, 2023
@jdbaldry jdbaldry mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

@kaydelaney kaydelaney Awaiting requested review from kaydelaney kaydelaney is a code owner automatically assigned from grafana/frontend-ops

Assignees

@adamyeats adamyeats

Labels
add to changelog area/datasource/frontend area/frontend backport A backport PR datasource/Azure Azure Monitor Datasource effort/small type/bug
Projects
None yet
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamyeats @aangelisc @zerok