Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrafanaUI: FileDropzone does not register full area as a drop target #71880

Closed
JoaoSilvaGrafana opened this issue Jul 18, 2023 · 5 comments · Fixed by #72170
Closed

GrafanaUI: FileDropzone does not register full area as a drop target #71880

JoaoSilvaGrafana opened this issue Jul 18, 2023 · 5 comments · Fixed by #72170
Assignees
Labels
area/grafana/ui Issues that belong to components in the @grafana/ui library help wanted type/bug

Comments

@JoaoSilvaGrafana
Copy link
Contributor

When dropping a file onto the FileDropzone, it only registers as a file being dragged over (or dropped on) when dropping on the very center of the control, rather than the full area.

Reproducable in Grafana:

  • Go to Dashboard Import /dashboard/import
  • Drag a file to the right side of the drop area

Image

Expected:

  • control should highlight if a file is dragging over any of the box

Actual:

  • control only highlights when dragged over the very centre of the element
@JoaoSilvaGrafana JoaoSilvaGrafana changed the title FileDropzone does not register full area as a drop target GrafanaUI: FileDropzone does not register full area as a drop target Jul 18, 2023
@JoaoSilvaGrafana JoaoSilvaGrafana added type/bug help wanted area/grafana/ui Issues that belong to components in the @grafana/ui library labels Jul 18, 2023
@kunxl-gg
Copy link
Contributor

kunxl-gg commented Jul 18, 2023

may I work on this issue

@JoaoSilvaGrafana
Copy link
Contributor Author

@kunxl-gg Yes feel free to pick it up! I have assigned it to you

@kunxl-gg
Copy link
Contributor

kunxl-gg commented Jul 20, 2023

Why is this stuck after yarn start. I was following the docs for local setup. I waited for way too long

Screenshot 2023-07-20 at 11 07 57 PM

@JoaoSilvaGrafana
Copy link
Contributor Author

Hi @kunxl-gg , I am not sure why it is so slow for you... For this specific issue you could try to do it with storybook only. If you run yarn install and yarn storybook is that stuck too?

@kunxl-gg
Copy link
Contributor

Hi @kunxl-gg , I am not sure why it is so slow for you... For this specific issue you could try to do it with storybook only. If you run yarn install and yarn storybook is that stuck too?

I resolved the error. Will make a PR shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grafana/ui Issues that belong to components in the @grafana/ui library help wanted type/bug
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants