Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudMonitoring: Correctly set title and text fields for annotations #71888

Merged
merged 1 commit into from Jul 21, 2023
Merged

CloudMonitoring: Correctly set title and text fields for annotations #71888

merged 1 commit into from Jul 21, 2023

Conversation

aangelisc
Copy link
Contributor

Fixes a regression that was introduced when the query properties were refactored. Correctly sets the title and text props on an annotation now.

Fixes #70612

@aangelisc aangelisc self-assigned this Jul 18, 2023
@aangelisc aangelisc requested a review from a team as a code owner July 18, 2023 19:01
@aangelisc aangelisc requested review from asimpson, bossinc, adamyeats and alyssabull and removed request for a team July 18, 2023 19:01
@aangelisc aangelisc modified the milestones: 10.1.x, 10.2.x Jul 18, 2023
@aangelisc aangelisc enabled auto-merge (squash) July 19, 2023 09:22
@adamyeats adamyeats mentioned this pull request Jul 19, 2023
Merged
asimpson
asimpson approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 🏆

@aangelisc aangelisc merged commit c4d6509 into main Jul 21, 2023
21 of 22 checks passed
@aangelisc aangelisc deleted the andreas/fix-gcm-annotations branch July 21, 2023 20:42
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 10.2.x, 10.1.x Jul 21, 2023
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Jul 21, 2023
Merged
grafana-delivery-bot bot pushed a commit that referenced this pull request Jul 21, 2023
@aangelisc @grafana-delivery-bot
CloudMonitoring: Correctly set title and text fields for annotations (#…
dd75874 
…71888)

Correctly set title and text fields

(cherry picked from commit c4d6509)
asimpson pushed a commit that referenced this pull request Jul 21, 2023
@grafana-delivery-bot @aangelisc
[v10.0.x] CloudMonitoring: Correctly set title and text fields for an…
9973270 
…notations (#72153)

CloudMonitoring: Correctly set title and text fields for annotations (#71888)

Correctly set title and text fields

(cherry picked from commit c4d6509)

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>
linoman pushed a commit that referenced this pull request Jul 24, 2023
@aangelisc @linoman
CloudMonitoring: Correctly set title and text fields for annotations (#…
f3ab583 
…71888)

Correctly set title and text fields
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
@asimpson asimpson mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson asimpson approved these changes

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

Assignees

@aangelisc aangelisc

Labels
add to changelog area/backend backport v10.0.x datasource/GoogleCloudMonitoring effort/small type/bug
Projects
Partner Datasources
Status: Done
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aangelisc @asimpson @ricky-undeadcoders @grafanabot