-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Custom contact point for OnCall in Grafana AM #72021
Conversation
…lled-oncall-contact-point-form
…lled-oncall-contact-point-form
…lled-oncall-contact-point-form
…lled-oncall-contact-point-form
…m-oncall-contact-point
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! Added a couple of questions/concerns regarding the components in grafana/ui. Also, I would love to get a demo of how this integration look to understand if this would be a good use case for UI extensions instead of spreading knowledge of the onCall app in alerting.
packages/grafana-ui/src/components/Forms/RadioButtonList/RadioButtonDot.tsx
Show resolved
Hide resolved
packages/grafana-ui/src/components/Forms/RadioButtonList/RadioButtonDot.tsx
Show resolved
Hide resolved
packages/grafana-ui/src/components/Forms/RadioButtonList/RadioButtonDot.tsx
Outdated
Show resolved
Hide resolved
@@ -23,7 +23,7 @@ export interface RadioButtonListProps<T> { | |||
className?: string; | |||
} | |||
|
|||
export function RadioButtonList<T>({ | |||
export function RadioButtonList<T extends string | number | readonly string[]>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could potentially be a breaking change have we considered that?
public/app/features/alerting/unified/components/receivers/form/CloudReceiverForm.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!🚀
Maybe @gillesdemey would be up for doing a demo? |
/deploy-to-hg |
|
|
I've added a demo to the PR's description |
I think I'd like to pass this opportunity to @konrad147 to demo the hard work he put in to this (aside from reviewing the PR and contributing my thoughts on the implementation I didn't put it quite as much effort) :) Is the demo Konrad attached to the PR helpful for the plugin team? We're always happy to schedule something and chat about the use-case too! |
Amazing, thanks 🙏🏻 Great work on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I might spend some time to see if this would be solvable (long term) with UI extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…m-oncall-contact-point
/deploy-to-hg |
|
|
What is this feature?
This PR adds support for a new custom contact point for the OnCall plugin
Additionally, it provides a better UI for integration with OnCall
Directly from the contact point page the user can create a new OnCall integration or select an existing one
Why do we need this feature?
To make the OnCall a first-party contact point
Who is this feature for?
All users with the OnCall plugin enabled
Which issue(s) does this PR fix?:
Fixes #67096 #69599 #69597
Special notes for your reviewer:
The new contact point operates in 3 modes depending on the OnCall plugin version
TODO:
grafana
tografana_alerting
DEMO
OnCall-Integration-Demo.mp4
Please check that: