Tempo: Remove traceqlSearch feature toggle #72029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrapereira
added
area/frontend
add to changelog
area/datasource/frontend
datasource/Tempo
no-backport
|
(Open the links below in a new tab to go to the correct steps)
|
grafanabot
added
levitate breaking change
adrapereira
requested review from
jcalisto and
jrbgraf
and removed request for
a team
| @@ -110,6 +99,11 @@ class TempoQueryFieldComponent extends React.PureComponent<Props, State> { | |||
| } | |||
| } | |||
|
|
|||
| // Show the deprecated search option if any of the deprecated search fields are set | |||
| if (query.spanName || query.serviceName || query.search || query.maxDuration || query.minDuration) { | |||
There was a problem hiding this comment.
Could we also check if queryType is nativeSearch
…earch_toggle # Conflicts: # docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
adrapereira
requested review from
ashharrison90,
JoaoSilvaGrafana and
academo
and removed request for
a team
adrapereira
requested review from
a team
and removed request for
jcalisto,
jrbgraf,
Eve832,
ashharrison90,
JoaoSilvaGrafana,
academo and
grafanabot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR removes the
traceqlSearchfeature toggle, setting the TraceQL Search editor as the editor of choice for the "Search" query type and deprecating the old "Native Search" editor.The goal is to deprecate the old native search, but not remove it completely from Grafana's code since there may still be users who use it for dashboards or through stored links. Instead, these users (and only these who were already using native search through a dashboard or stored link) will see a deprecation alert asking them to migrate to another query type.
The PR also includes a small refactor/reorg of some components of the Tempo data source.
Who is this feature for?
All users of the Tempo data source.
Which issue(s) does this PR fix?:
Fixes #65825
Special notes for your reviewer:
Please check that: