Loki: Enable Query Splitting by default #72094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyax
requested review from
summerwollin and
dafydd-t
and removed request for
a team
linoman
pushed a commit
that referenced
this pull request
Jul 24, 2023
* lokiQuerySplitting: enable feature flag by default * Query stats: add special note for stats + splitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to different query performance scenarios, we implemented query splitting, where queries that request more than a day of data are split in sub-requests of 1 day duration each. For example, requesting 7 days of logs will produce 7 requests of 1 day.
This PR makes this the default behavior for querying Loki.
Additionally, we're adding a tooltip to explain how query limits apply when querying with splitting enabled.
If needed, this feature can be disabled by setting
lokiQuerySplittingtofalse.Which issue(s) does this PR fix?:
Closes #67547
Fixes #67548
Special notes for your reviewer:
Remove the feature flag from custom.ini.
The default querying behavior should be with query splitting for queries with > 1 day duration.