Feature toggles management: Define get feature toggles api #72106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalisto
force-pushed
the
feature-toggles-management/api
branch
from
8fa590c
to
f26e382
Compare
jcalisto
force-pushed
the
feature-toggles-management/api
branch
from
f26e382
to
39dcbac
Compare
jcalisto
requested review from
PoorlyDefinedBehaviour,
IbrahimCSAE,
eleijonmarck,
Jguer,
sakjur,
papagian and
yangkb09
and removed request for
a team
torkelo
reviewed
Jul 21, 2023
| ################################## Feature Management ############################################## | ||
| [feature_management] | ||
| # Hides specific feature toggles from the feature management page | ||
| hidden_toggles = |
There was a problem hiding this comment.
Do we need these as instance level config? (Vs just options in each feature)
There was a problem hiding this comment.
These configs were proposed during our DNA discussion, as they could be useful for operators (HG or others) to decide which features their grafana administrators would be able to tune in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Added a new endpoint to allow admin users to fetch a list of feature toggles and whether they are enabled on the instance.
Also added a hidden_toggles and read_only_toggles config for the operator to have control on the displayed feature toggles.
Why do we need this feature?
We are creating a Feature Toggle Management page within grafana, where the user can see (and update in the future) the current feature toggles state.
Who is this feature for?
Grafana Administrators
Which issue(s) does this PR fix?:
Fixes #70923
Implements GET endpoint #70922