NestedFolders: Enable new nested folder picker by default for nested folders #72129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhunt
requested review from
leandro-deveikis and
mmandrus
and removed request for
a team
joshhunt
force-pushed
the
joshhunt/nested-folder-picker-by-default
branch
from
93602ea
to
91ea8aa
Compare
joshhunt
changed the title
|
Note - we cannot merge this until we've moved to the new wrapper FolderPicker component in the save dashboard form and dashboard settings settings. |
joshhunt
force-pushed
the
joshhunt/nested-folder-picker-by-default
branch
from
91ea8aa
to
aeff214
Compare
|
e2e tests needs updating. probably need to add e2e selectors to the new folder picker also |
joshhunt
force-pushed
the
joshhunt/nested-folder-picker-by-default
branch
from
aeff214
to
0eeb4c3
Compare
ashharrison90
approved these changes
Jul 24, 2023
| @@ -31,7 +31,7 @@ func TestFeatureToggleFiles(t *testing.T) { | |||
| t.Run("check registry constraints", func(t *testing.T) { | |||
| for _, flag := range standardFeatureFlags { | |||
| if flag.Expression == "true" && flag.Stage != FeatureStageGeneralAvailability { | |||
| t.Errorf("only stable features can be enabled by default. See: %s", flag.Name) | |||
| t.Errorf("only FeatureStageGeneralAvailability features can be enabled by default. See: %s", flag.Name) | |||
There was a problem hiding this comment.
was this changed by the test running? 🤔
There was a problem hiding this comment.
I changed this manually...
There was a problem hiding this comment.
ah whoops, i misread. thought this was a generated file 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the new folder picker UI that uses the full nested folder hierarchy, enabled by default when the
nestedFoldersfeature flag is also enabled.At the moment the new picker is used in new Browse Dashboards UI, Save Dashboard, and Dashboard Settings. Future pull requests will enable it more broadly.
nestedFolderpicker.mp4
Fixes #65745