Feat: Feature toggle admin page frontend interface #72164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IbrahimCSAE
requested review from
L-M-K-B,
JoaoSilvaGrafana,
vtorosyan,
Jguer,
sakjur,
mildwonkey and
suntala
and removed request for
a team
IbrahimCSAE
changed the title
github-actions
bot
added
area/backend
area/frontend
pr/external
IbrahimCSAE
changed the title
IbrahimCSAE
removed request for
L-M-K-B,
JoaoSilvaGrafana,
vtorosyan,
Jguer,
sakjur,
mildwonkey and
suntala
IbrahimCSAE
changed the title
mmandrus
requested review from
a team,
joshhunt and
L-M-K-B
and removed request for
a team
joshhunt
reviewed
Aug 1, 2023
tskarhed
reviewed
Aug 1, 2023
mmandrus
previously approved these changes
Aug 1, 2023
mmandrus
dismissed
their stale review
dismissing as there are other requested changes. Maybe we should use the fancy table component here instead?
joshhunt
reviewed
Aug 1, 2023
mmandrus
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
LGTM - got a walk-through from @IbrahimCSAE showing me all the comments and resulting changes.
We will be iterating on this page, so if you have any further comments, please share in #proj-feature-toggle-admin-page in slack
aishyandapalli
pushed a commit
to aishyandapalli/grafana
that referenced
this pull request
Aug 16, 2023
* feature toggles admin page proto * feature toggle admin page proto * keep phase 1 code only * latest update with api * fix * fix * add correct premissions in admin.go * move behind toggle * Use InteractiveTable * guard behind feature toggle * use RTK * route in api.go * fixes
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
* feature toggles admin page proto * feature toggle admin page proto * keep phase 1 code only * latest update with api * fix * fix * add correct premissions in admin.go * move behind toggle * Use InteractiveTable * guard behind feature toggle * use RTK * route in api.go * fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Added a new admin page to allow admin users to view a list of feature toggles and their status on their grafana instance.
Why do we need this feature?
We are creating a Feature Toggle Management page within grafana, where the user can see (and update in the future) the current feature toggles state.
Who is this feature for?
Grafana Administrators
Which issue(s) does this PR fix?:
Fixes #70784 & https://github.com/grafana/grafana-operator-experience-squad/issues/608