Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.0.x] AzureMonitor: Fix ResourcePicker hanging #72357

Merged
merged 1 commit into from
Jul 26, 2023
Merged

[v10.0.x] AzureMonitor: Fix ResourcePicker hanging #72357

merged 1 commit into from
Jul 26, 2023

Conversation

asimpson
Copy link
Contributor

Backport 722f787 from #71886

Removed location fetching for every subscription.

I also started reporting the number of subscriptions so hopefully we can have a better understanding of how many subscriptions customers are bringing to the datasource.

Fixes #70523

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@asimpson
AzureMonitor: Fix ResourcePicker hanging (#71886)
66c7d5d 
* AzureMonitor: Fix ResourcePicker hanging

Removed location fetching for every subscription.

Fixes #70523

* fix region for multi metricnames

* fix tests

* fix e2e

* remove regions/locations from variable editor

* remove region pieces from e2e

(cherry picked from commit 722f787)
@asimpson asimpson added this to the 10.0.x milestone Jul 26, 2023
@asimpson asimpson requested a review from a team as a code owner July 26, 2023 13:06
@asimpson asimpson requested review from bossinc, aangelisc, adamyeats and alyssabull and removed request for a team July 26, 2023 13:06
@asimpson asimpson enabled auto-merge (squash) July 26, 2023 13:06
@github-actions
Copy link
Contributor

Backend code coverage report for PR #72357
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #72357

Plugin Main PR Difference
azuremonitor 86.27% 84.76% -1.51%

@asimpson asimpson merged commit 75891ac into v10.0.x Jul 26, 2023
18 checks passed
@asimpson asimpson deleted the backport-71886-to-v10.0.x branch July 26, 2023 14:03
@zerok zerok modified the milestones: 10.0.x, 10.0.4 Aug 22, 2023
@jdbaldry jdbaldry mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bossinc bossinc bossinc approved these changes

@aangelisc aangelisc Awaiting requested review from aangelisc aangelisc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR datasource/Azure Azure Monitor Datasource type/bug
Projects
None yet
Milestone
10.0.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asimpson @bossinc @zerok