[v10.0.x] Dashboard: New Datasource picker link is keyboard accessible #72371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP * fixes for readability * fix * WIP * Keep tab index working with portal * Use callback and clean up * Fix linting errors * Ignore clickable element --------- Co-authored-by: Ivan Ortega <ivanortegaalba@gmail.com> (cherry picked from commit cae68b9)
polibb
added
type/bug
area/frontend
add to changelog
backport
ivanortegaalba
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport cae68b9 from #72134
What is this feature?
This should allow the user to tab their way from the input of the Datasource picker to the buttons underneath the list of available datasources in its dropdown.
Why do we need this feature?
Keyboard accessibility for the dropdown of the datasource picker.
Which issue(s) does this PR fix?:
Fixes #69109
Special notes for your reviewer: