Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLDS: Move Text component from the unstable package to grafana-ui #72660

Merged
merged 3 commits into from
Aug 2, 2023
Merged

GLDS: Move Text component from the unstable package to grafana-ui #72660

merged 3 commits into from
Aug 2, 2023

Conversation

eledobleefe
Copy link
Contributor

What is this feature?

We move the Text component from the unstable package to grafana-ui.

Why do we need this feature?

To turn Text into a stable component and make it available through grafana-ui

Who is this feature for?

Everybody

Which issue(s) does this PR fix?:

Fixes #72659

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@eledobleefe eledobleefe added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes saga design system Issues related to the work of the Saga Design System saga ds: component Issues related to Saga Design System Components saga ds: dev work Dev only issues related to Saga Design System labels Aug 1, 2023
@eledobleefe eledobleefe added this to the 10.2.x milestone Aug 1, 2023
@eledobleefe eledobleefe self-assigned this Aug 1, 2023
@eledobleefe eledobleefe requested review from a team as code owners August 1, 2023 08:20
@eledobleefe eledobleefe added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Aug 1, 2023
JoaoSilvaGrafana
JoaoSilvaGrafana approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

gillesdemey
gillesdemey approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@gillesdemey gillesdemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the alerting team 👍

@eledobleefe eledobleefe merged commit 7ec9a0c into main Aug 2, 2023
32 checks passed
@eledobleefe eledobleefe deleted the eledobleefe/glds-text-from-unstable-to-grafanaui-72659 branch August 2, 2023 12:58
aishyandapalli pushed a commit to aishyandapalli/grafana that referenced this pull request Aug 16, 2023
@eledobleefe @aishyandapalli
GLDS: Move Text component from the unstable package to grafana-ui (…
9734914 
…grafana#72660)
chauchausoup pushed a commit to chauchausoup/grafana that referenced this pull request Sep 15, 2023
@eledobleefe @chauchausoup
GLDS: Move Text component from the unstable package to grafana-ui (…
2ef1a9c 
…grafana#72660)
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@dnhn dnhn mentioned this pull request Oct 24, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gillesdemey gillesdemey gillesdemey approved these changes

@JoaoSilvaGrafana JoaoSilvaGrafana JoaoSilvaGrafana approved these changes

@tskarhed tskarhed Awaiting requested review from tskarhed tskarhed is a code owner automatically assigned from grafana/grafana-frontend-platform

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90 ashharrison90 is a code owner automatically assigned from grafana/grafana-frontend-platform

@polibb polibb Awaiting requested review from polibb polibb is a code owner automatically assigned from grafana/dashboards-squad

@evictorero evictorero Awaiting requested review from evictorero evictorero is a code owner automatically assigned from grafana/dashboards-squad

@academo academo Awaiting requested review from academo academo is a code owner automatically assigned from grafana/plugins-platform-frontend

@VikaCep VikaCep Awaiting requested review from VikaCep VikaCep is a code owner automatically assigned from grafana/alerting-frontend

@konrad147 konrad147 Awaiting requested review from konrad147 konrad147 is a code owner automatically assigned from grafana/alerting-frontend

@soniaAguilarPeiron soniaAguilarPeiron Awaiting requested review from soniaAguilarPeiron soniaAguilarPeiron is a code owner automatically assigned from grafana/alerting-frontend

Assignees

@eledobleefe eledobleefe

Labels
add to changelog area/frontend no-backport Skip backport of PR saga design system Issues related to the work of the Saga Design System saga ds: component Issues related to Saga Design System Components saga ds: dev work Dev only issues related to Saga Design System
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

Move Text component from the unstable package to grafana-ui
4 participants
@eledobleefe @gillesdemey @JoaoSilvaGrafana @zerok