Auth: Add key_id config param to auth.jwt #72711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyongyosi
requested review from
papagian,
suntala and
yangkb09
and removed request for
a team
linoman
approved these changes
Aug 2, 2023
Thanks, I updated defaults.ini, but forgot to update sample.ini, I'm gonna update it! |
Jguer
approved these changes
Aug 2, 2023
Jguer
approved these changes
Aug 2, 2023
IevaVasiljeva
approved these changes
Aug 2, 2023
chri2547
approved these changes
Aug 2, 2023
mgyongyosi
added a commit
that referenced
this pull request
Aug 3, 2023
* Specify keyID for public key provided in PEM format for JWT Auth * Update docs * Update sample.ini (cherry picked from commit bba11d0)
aishyandapalli
pushed a commit
to aishyandapalli/grafana
that referenced
this pull request
Aug 16, 2023
* Specify keyID for public key provided in PEM format for JWT Auth * Update docs * Update sample.ini
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
* Specify keyID for public key provided in PEM format for JWT Auth * Update docs * Update sample.ini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds a new configuration option to
auth.jwtto specify a predefined key id (key_id) for the public key when the public key is configured as a PEM formatted file (using thekey_fileconfiguration option).Why do we need this feature?
It is possible (and supported by Grafana) to use a PEM formatted public key instead of the recommended JWKS url/file, and it can happen that the JWT token's header contains a
kidfor specifying the key id that should be used to verify the signature. Previously when thekidwas specified the verification failed, because the key with the specified key id was not found.Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #71665
Special notes for your reviewer:
Please check that: