-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Add support for Tempo query variables #72745
Conversation
5065309
to
9357626
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review the code but approving based on the functionality demonstrated. Amazing work!
We have discussed in a separate thread that we should create another PR that ensures Tempo query variables work when the dashboard panel query is made via the Search
tab. Today they only work if the query is made via the TraceQL
tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we modify the fields here so that there is one per row? We could also shorten the label width here as they seem quite long. In contrast, I think we should make the second fields dropdown input a bit longer. As you can see in the image, it's quite short which makes it hard to see what was selected in the dropdown.
@fabrizio-grafana did you talk with somebody regarding whether we need or don't need also a search result (so TraceIDs) as a template variable? |
@aocenas -- This is something we're leaving out of scope for now and will revisit in the future if there is sufficient demand. |
7de7e50
to
065ab6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good and will be a great addition :)
I've noticed something that we should fix before merging. Nothing major so should be ok to fix. Querying the v2 endpoint always returns an error because we are not providing the scope in the query.
i.e. the query is like api/v2/search/tag/job/values
when it should be api/v2/search/tag/resource.job/values
. As a result, we always fallback to v1 of the API. In this case I believe that tags result are the exact same so this still works, however we should probably fix the issue with the API v2 tags query as we will more than likely eventually drop support for v1 and move to v2 + it removes one error from the network tab/console.
45f0c36
to
285b002
Compare
Should be fixed! |
be4de1e
to
8db66e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! 👍
8db66e5
to
1549cea
Compare
What is this feature?
Add support for template variables (
Label names
andLabel values
) in Tempo, similarly to what is already available in Loki and Prometheus. Quick demo.Why do we need this feature?
It has been requested by a few customers and discussed with @09jvilla.
Who is this feature for?
Customers.
Which issue(s) does this PR fix?:
Fixes #72575
Fixes #70305