Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Monitoring: Support AliasBy property in MQL mode #73116

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Cloud Monitoring: Support AliasBy property in MQL mode #73116

merged 6 commits into from
Aug 10, 2023

Conversation

alyssabull
Copy link
Contributor

@alyssabull alyssabull commented Aug 9, 2023 •
edited by aangelisc
Loading

Adds support for AliasBy in Builder Mode and preserves AliasBy when switching between MQL and Builder mode.

Screenshot 2023-08-09 at 9 10 20 AM

Fixes grafana/support-escalations#7004

@alyssabull alyssabull added this to the 10.1.x milestone Aug 9, 2023
@alyssabull alyssabull self-assigned this Aug 9, 2023
@alyssabull alyssabull requested a review from a team as a code owner August 9, 2023 15:11
@alyssabull alyssabull requested review from asimpson, bossinc, aangelisc and adamyeats and removed request for a team August 9, 2023 15:11
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 10.1.x, 10.2.x Aug 9, 2023
aangelisc
aangelisc approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Great stuff, I'd add a test just to avoid a regression in future but nice work 😊

@aangelisc aangelisc changed the title Cloud Monitoring: Support AliasBy property in Builder mode Cloud Monitoring: Support AliasBy property in MQL mode Aug 9, 2023
@aangelisc
Copy link
Contributor

10/10! Great stuff @alyssabull 😊

asimpson
asimpson approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 🚀

@alyssabull alyssabull merged commit eeefa7d into main Aug 10, 2023
15 checks passed
@alyssabull alyssabull deleted the alyssa/gcm-preserve-aliasby branch August 10, 2023 16:55
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Aug 10, 2023
Merged
grafana-delivery-bot bot pushed a commit that referenced this pull request Aug 10, 2023
@alyssabull @grafana-delivery-bot
Cloud Monitoring: Support AliasBy property in MQL mode (#73116)
873f154 
(cherry picked from commit eeefa7d)
aangelisc pushed a commit that referenced this pull request Aug 10, 2023
@grafana-delivery-bot @alyssabull
[v10.0.x] Cloud Monitoring: Support AliasBy property in MQL mode (#73165
2aecfed 
)

Cloud Monitoring: Support AliasBy property in MQL mode (#73116)

(cherry picked from commit eeefa7d)

Co-authored-by: Alyssa Bull <58453566+alyssabull@users.noreply.github.com>
aishyandapalli pushed a commit to aishyandapalli/grafana that referenced this pull request Aug 16, 2023
@alyssabull @aishyandapalli
Cloud Monitoring: Support AliasBy property in MQL mode (grafana#73116)
3d7c17d
@zerok
Copy link
Contributor

zerok commented Aug 22, 2023

Hi :) Looks like this never made it into the v10.1.x branch. Is this only required for 10.0.x?

@aangelisc
Copy link
Contributor

Hey @zerok, thanks for picking this up. We should probably backport to v10.1.x as well just incase 😊

@asimpson asimpson mentioned this pull request Sep 8, 2023
Closed
chauchausoup pushed a commit to chauchausoup/grafana that referenced this pull request Sep 15, 2023
@alyssabull @chauchausoup
Cloud Monitoring: Support AliasBy property in MQL mode (grafana#73116)
c2129a4
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@dnhn dnhn mentioned this pull request Oct 24, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson asimpson approved these changes

@aangelisc aangelisc aangelisc approved these changes

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

Assignees

@alyssabull alyssabull

Labels
add to changelog area/frontend backport v10.0.x datasource/GoogleCloudMonitoring type/bug
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssabull @aangelisc @zerok @asimpson