Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: PanelChrome - remove untitled placeholder and add border when panel is transparent #73150

Merged
merged 3 commits into from Aug 10, 2023

Conversation

axelavargas
Copy link
Member

What is this feature?

During the redesign of the panel header, we decided to add a placeholder name, "Untitled". This decision was based on feedback about the menu not being discoverable and the drag icon conflicting with the menu icon, which looked like nine dots.
After receiving both internal and external feedback, we decided to remove this placeholder. It was causing confusion and wasn't adding enough value, especially since the original issues were addressed differently.

This PR addresses two issues:

  1. It removes the "Untitled" placeholder.
Before After

image

image

  1. It adds a border on hover when the panel is transparent.
Before After
Before-hoverWhenTransparentBackground.mp4
hoverWhenTransparentBackground.mp4

Why do we need this feature?
Removes the current confusion about panels without headers.

Who is this feature for?

Everyone

Which issue(s) does this PR fix?:

Fixes #72978, #70510

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Copy link
Contributor

@juanicabanas juanicabanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I loved the border change 🚀

@axelavargas axelavargas merged commit 0dcba09 into main Aug 10, 2023
32 checks passed
@axelavargas axelavargas deleted the axelav/panel-header-untitled-transparency branch August 10, 2023 13:17
aishyandapalli pushed a commit to aishyandapalli/grafana that referenced this pull request Aug 16, 2023
chauchausoup pushed a commit to chauchausoup/grafana that referenced this pull request Sep 15, 2023
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@craftzneko
Copy link

craftzneko commented Apr 24, 2024

The border around a panel when transparent is kind of a pain for my use case. I have multiple panels (using dynamic text plugin) that pass data between them and the overall look is off a portal style page. I feel this should be an option that is selectable in properties. Also the pop up Untitled (or even just the move icon) should not really appear for users who have no permissions to edit the page, why would they be shown options they cant use? I know this has been asked so many times over the years but sometimes we just want to present a dashboard with no interactions except for the interactions we design. For others looking to remove the border and the panel menu. If you are using a plugin that allows you to directly add JS (such as the amazing Dynamic Text) you can add this (wrap it in a docready function so the page loads first)

  let elements = document.querySelectorAll('[class*="panel-container-panel-transparent-container"]');

  elements.forEach(element => {
    element.style.border = 'none';
  });

  let hoverElements = document.querySelectorAll('[class*="hover-container-widget"]');

  hoverElements.forEach(element => {
    element.style.visibility = 'hidden';
  });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[panel] "Untitled" title appears when not giving a title to a panel.
4 participants