Feat: Feature toggle admin page frontend write UI and InteractiveTable sorting #73533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IbrahimCSAE
requested review from
mgyongyosi,
Jguer,
papagian,
zserge and
mildwonkey
and removed request for
a team
IbrahimCSAE
added
add to changelog
pr/external
|
/deploy-to-hg |
|
|
/deploy-to-hg |
|
|
|
/deploy-to-hg |
|
|
/deploy-to-hg |
|
/deploy-to-hg |
|
|
|
/deploy-to-hg |
|
/deploy-to-hg |
|
|
jcalisto
approved these changes
Aug 30, 2023
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
…e sorting (grafana#73533) * updates * make save button always visible but disabled * only reset toggles if there isn't an error response * make linters happy * update post body to match backend * fix linter again * be smarter about sorting of empty descriptions * run prettier * fix payload * Re-add disabled to switch --------- Co-authored-by: Joao Calisto <joao.santana.calisto@gmail.com> Co-authored-by: Michael Mandrus <michael.mandrus@grafana.com>
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
…e sorting (#73533) * updates * make save button always visible but disabled * only reset toggles if there isn't an error response * make linters happy * update post body to match backend * fix linter again * be smarter about sorting of empty descriptions * run prettier * fix payload * Re-add disabled to switch --------- Co-authored-by: Joao Calisto <joao.santana.calisto@gmail.com> Co-authored-by: Michael Mandrus <michael.mandrus@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Why do we need this feature?
We are creating a Feature Toggle Management page within Grafana, where the user can see and update the current feature toggles state.
Who is this feature for?
Grafana Administrators
Which issue(s) does this PR fix?:
Fixes #73056 [Use more Interactive Table features in feature toggle admin page]
Fixes #73060 [Feature toggle admin page should support toggle updates]