Pyroscope: Template variable support #73572
Conversation
aocenas
force-pushed
the
aocenas/pyroscope/template-variables
branch
from
9944b38
to
30c7772
Compare
aocenas
requested review from
L-M-K-B,
eledobleefe and
Rperry2174
and removed request for
a team,
L-M-K-B and
eledobleefe
aocenas
added
add to changelog
add to what's new
datasource/grafana-pyroscope
| @@ -113,7 +115,7 @@ export class Cascader extends PureComponent<CascaderProps, CascaderState> { | |||
| for (const option of searchableOptions) { | |||
| const optionPath = option.value || []; | |||
|
|
|||
| if (optionPath.indexOf(initValue) === optionPath.length - 1) { | |||
| if (optionPath[optionPath.length - 1] === initValue) { | |||
There was a problem hiding this comment.
@tskarhed 2 small fixes here. This could have failed to select option if main and child option have the same value. Seems easier to just test the leaf and compare that.
Also the separator had spaces around when used for custom values vs for other values so unified that.
| @@ -0,0 +1,77 @@ | |||
| import React, { useEffect, useMemo, useState } from 'react'; | |||
There was a problem hiding this comment.
Most of this was just moved to separate component so it can be reused in variable editor
There was a problem hiding this comment.
Nice touch to allow variables within the VariableQueryEditor 👍
-
Clicking an item in the cascader updates the value even if it's incomplete. I would expect this for a leaf value such as
process_cpu-samplesbut if I'm just clickingmemoryormutexfor example, I may only be taking a look at the options, rather than wanting to actually change theprofileType. I would have to navigate back to my previous selection after clicking on anything in the cascader, if my intent was not actually to change the value. Is there a specific reason we update the cascader when any option is clicked? If it's so users can see their selection/breadcrumb I wonder could we update the UI when they click an options but not update the actual state until they have finished their selection down to the leaf? -
Error if I don't select
Profile typeorLabel. Error seems expected as no values to map but still should be handled gracefully.
-
Other than those few comments, this looks really good!
public/app/plugins/datasource/grafana-pyroscope-datasource/QueryEditor/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/grafana-pyroscope-datasource/VariableQueryEditor.test.tsx
Show resolved
Hide resolved
public/app/plugins/datasource/grafana-pyroscope-datasource/VariableQueryEditor.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/grafana-pyroscope-datasource/VariableQueryEditor.tsx
Show resolved
Hide resolved
Fixed.
Fixed. Seems like other data sources just don't run query if some data is missing so done the same. |
Adds template variable support for pyroscope. This includes
Variables in dashboard settings
Variable editor
Dashbard with variables
Query editor
Also one change to make this work was to make the profile selector in pyroscope query editor work with custom values:
testing
Use pyroscope or phlare dev env block and create dashboard creating variables similar to those in screenshots.