[v10.1.x] Logs: Fix log samples not present with empty first frame #73622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
* fix log samples not present with empty first frame * also test with empty frames * rename test file * remove import (cherry picked from commit 997d21f)
grafana-delivery-bot
bot
added
add to changelog
area/explore
area/frontend
area/logs
backport
svennergr
approved these changes
Aug 22, 2023
|
Backend code coverage report for PR #73622 |
|
Frontend code coverage report for PR #73622
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 997d21f from #73612
What is this feature?
When using log samples with multiple queries, and the first query returning 0 log results, no log samples would be displayed, while the second query would produce results. This behavior is fixed in this PR.
Which issue(s) does this PR fix?:
Fixes #73531
Special notes for your reviewer:
A:
sum(count_over_time({instance="server\\1", place="moon", foo="bar"} [$__auto]))B:
sum(count_over_time({instance="server\\1", place="moon"} [$__auto]))