[v10.1.x] Alerting: Fix incorrect timing meta information for policy #73695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
(cherry picked from commit a01a903)
grafana-delivery-bot
bot
requested review from
gillesdemey,
VikaCep,
konrad147 and
soniaAguilarPeiron
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/alerting
gillesdemey
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a01a903 from #73675
What is this feature?
This PR does two things
computeInheritedTreefunction to utils and adds a few testsPolicycomponent to no longer show the default timing options if we're also inheriting from the parent.Which issue(s) does this PR fix?:
Fixes #73573
The inheritance algorithm was working as intended, but the component showed both the default timing options and inherited properties, which it shouldn't (with the exception of the default policy, which cannot inherit from a parent).
Special notes for your reviewer:
I didn't write a regression test for this in
Policy.test.tsxbut might be a good addition to this PR :)