Grafana/ui: Expose trigger method from useForm to children
#73831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiruiz01
requested review from
joshhunt,
L-M-K-B and
mckn
and removed request for
a team
|
|
L-M-K-B
reviewed
Aug 29, 2023
|
I added the issue where this change will be used 👍 |
L-M-K-B
approved these changes
Aug 31, 2023
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
…#73831) Form: Expose trigger method from useForm to children
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
Form: Expose trigger method from useForm to children
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR exposes the
triggermethod fromuseFormto the children components ofForm.Why do we need this feature?
(Link to docs) It allows to manually trigger form validation. A workaround can be made when
triggernot available, but there is no real reason not to expose this method to the children components.Almost all the other methods from
useFormare returned, so it makes sense to also return this one.For example, when building a Stepper component, you might need to trigger validation of the whole form on the last step to ensure there are no errors.
Who is this feature for?
Users of the
Formcomponent from@grafana/ui.Which issue(s) does this PR fix?
Fixes issue #94.