[v10.1.x] Dashboard: Fix Variable Dropdown to Enforce Minimum One Selection when 'All' Option is Configured #73927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 97c3cd1 from #69839
What is this feature?
When 'Selected(n)' is clicked to deselect all, the behavior is inconsistent; sometimes it defaults back to 'All', and at other times, it leaves an empty field.
I've modified the logic to use the 'Selected(n)' to toggle between standard options and the 'All' option.
Important:
I retained the existing UI and enforced the selection of at least one option, which can be either a standard option or the 'All' option.
The enforcing part is only applied when the "All" option is configured, these changes don't address the enforcement otherwise.
225590713-b71e2309-ff9c-475b-8c6a-01151814f37b.1.mov
DropdownVariableWithAllOptionBorder.mp4
Who is this feature for?
Everyone
Which issue(s) does this PR fix?:
Fixes #64887
Special notes for your reviewer:
I modified the UI slightly and added a border-bottom, this in my opinion brings more clarity to the users about the special "All" option we allow to configure.
Please check that: