Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.1.x] Dashboard: Fix Variable Dropdown to Enforce Minimum One Selection when 'All' Option is Configured #73927

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 97c3cd1 from #69839


What is this feature?

When 'Selected(n)' is clicked to deselect all, the behavior is inconsistent; sometimes it defaults back to 'All', and at other times, it leaves an empty field.

I've modified the logic to use the 'Selected(n)' to toggle between standard options and the 'All' option.

Important:

I retained the existing UI and enforced the selection of at least one option, which can be either a standard option or the 'All' option.
The enforcing part is only applied when the "All" option is configured, these changes don't address the enforcement otherwise.

Before: The user was not forced to select an option After - Enforced the selection of at least one option, which can be either a standard option or the 'All' option.
225590713-b71e2309-ff9c-475b-8c6a-01151814f37b.1.mov
DropdownVariableWithAllOptionBorder.mp4

Who is this feature for?

Everyone

Which issue(s) does this PR fix?:

Fixes #64887

Special notes for your reviewer:

I modified the UI slightly and added a border-bottom, this in my opinion brings more clarity to the users about the special "All" option we allow to configure.

Before After

image

image

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

…n 'All' Option is Configured (#69839)

(cherry picked from commit 97c3cd1)
Copy link
Member

@axelavargas axelavargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bot 🤖

@axelavargas axelavargas enabled auto-merge (squash) August 28, 2023 12:47
@axelavargas axelavargas merged commit bfab6cc into v10.1.x Aug 28, 2023
18 checks passed
@axelavargas axelavargas deleted the backport-69839-to-v10.1.x branch August 28, 2023 12:56
@guicaulada guicaulada modified the milestones: 10.1.x, 10.1.1 Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants