Plugins: Add dependency column in version table #73991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshirohugo
changed the title
| @@ -26,6 +26,7 @@ export const VersionList = ({ versions = [], installedVersion }: Props) => { | |||
| <tr> | |||
| <th>Version</th> | |||
| <th>Last updated</th> | |||
| <th>Dependency</th> | |||
There was a problem hiding this comment.
Suggested change
| <th>Dependency</th> | |
| <th>Grafana Dependency</th> |
There was a problem hiding this comment.
- I think this makes it more understandable by users 😄
- Consider cases where there are additional dependencies like with synthetic monitoring, we're only showing the Grafana version dependency so we should make that clear.
I considered Grafana Version but that might cause confusion with the deprecated grafanaVersion in plugin.json and Grafana Version Dependency which felt too wordy.
sympatheticmoose
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Nice work on this and fast turnaround 🚀 Please see comments for suggested change
I would like to incorporate this into our documentation on plugin management... but we would need to add a lot more before this specific addition would make sense, so don't worry for now, I will raise a follow up issue.
sympatheticmoose
approved these changes
Aug 29, 2023
oshirohugo
deleted the
introduce-dependency-column-in-version-history-table
branch
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
* Plugins: add dependency column in version table * Closes grafana#44052
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Plugins: add dependency column in version table * Closes #44052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Introduce Dependency column in Version History table
Why do we need this feature?
This is necessary to give better info about a plugin previous versions
Who is this feature for?
Plugins users
Which issue(s) does this PR fix?:
#44052
Special notes for your reviewer:
Please check that: